blevesearch / bleve / 35708798869

52%

Build Type

push

github

Committed by web-flow

Commit Message

MB-73970: Skip writing fileWriter trailer to index metadata when unset (#2400)

Save() and UpdateWriter() unconditionally appended the file callback id
plus its 4-byte length to index_meta.json, even when no callback was
registered - in that case Id() is "" and the append still writes a
4-byte zero-length trailer after the JSON body.

That trailer breaks any older bleve reader that predates this callback
mechanism: openIndexMeta() there does a single strict json.Unmarshal
with no fallback, so trailing bytes after the closing '}' make it fail
with ErrorIndexMetaCorrupt - even though the index itself is fine and
never used a callback. This surfaced as a hard failure when a pindex's
on-disk files were copied (e.g. via cbgt's file-transfer-based
rebalance) from a node running this bleve version to a node running an
older one.

Only emit the trailer when fileWriter.Id() is non-empty, i.e. when a
callback is actually in use, keeping the no-callback case byte-for-byte
identical to the pre-existing index_meta.json format.

Coverage Stats

1 of 18 new or added lines in 1 file covered. (5.56%)

16 existing lines in 3 files now uncovered.

20145 of 38974 relevant lines covered (51.69%)

0.58 hits per line