hyperledger-labs / fabric-smart-client / 35707228429
91%

DEFAULT BRANCH: main
Ran
Jobs 22
Files 502
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 86.111% (+0.07%) from 86.039%
35707228429

push

github

web-flow 
test(fabric): cover the postgres db driver (#1857)

platform/fabric/services/db/driver/sql/postgres had no test file. Split the
coverage along the line of what needs a database.

driver_test.go needs none: a stub postgres2.DbProvider handing out an sqlmock
RWDB covers the driver surface, the four store constructors over
{valid, invalid config, db-open failure}, and the build* helpers.

Each build* helper picks one table out of TableNames, and holds it in an
unexported field. The store is therefore asserted through the query it issues,
under sqlmock's exact matcher, since that is the only place the choice is
observable and the only thing that catches a store wired to a sibling's table.

vault_test.go covers Store and CreateSchema against a container, as those touch
the database. GetState and GetTxStatus return (nil, nil) for a missing row, so
every result is checked for nil before it is dereferenced: a bare dereference
panics instead of failing, which aborts the binary and hides the other results.

The container tests are named TestPostgres... so CI's --run '(Postgres)' gate
picks them up and --skip '(Postgres)' leaves them out.

Coverage goes from 0% to 53.4% with no database, and to 89.0% with one. What
remains is Store's mid-transaction error returns, which need a failure-injecting
driver to reach.

Closes #1827

Signed-off-by: Said Altury <Said.Altury@ibm.com>

27522 of 31961 relevant lines covered (86.11%)

2763.79 hits per line

Coverage Regressions

Lines Coverage ∆ File
2
92.86
-2.38% platform/view/services/comm/service.go
2
83.93
-0.55% platform/view/services/comm/host/websocket/ws/multiplexed_provider.go
2
92.35
-0.59% platform/fabric/core/generic/ordering/bft.go
1
97.61
-0.4% platform/fabricx/core/finality/nlm.go
1
89.03
0.65% platform/view/services/comm/session.go
Jobs
ID Job ID Ran Files Coverage
1 utest-extensions - 35707228429.1 8
52.57
GitHub Action Run
2 itest-fsc-stoprestart - 35707228429.2 241
33.56
GitHub Action Run
3 itest-fabric-iou-libp2p - 35707228429.3 458
36.59
GitHub Action Run
4 itest-fabric-configupdate - 35707228429.4 458
38.81
GitHub Action Run
5 itest-fabric-atsachaincode - 35707228429.5 453
30.92
GitHub Action Run
6 utest-postgres - 35707228429.6 493
9.79
GitHub Action Run
7 itest-fabric-iouhsm - 35707228429.7 458
39.68
GitHub Action Run
8 utest-root - 35707228429.8 493
82.86
GitHub Action Run
9 itest-fabricx-configupdate - 35707228429.9 480
28.54
GitHub Action Run
10 itest-fabric-events - 35707228429.10 453
29.04
GitHub Action Run
11 itest-fabric-stoprestart - 35707228429.11 448
31.2
GitHub Action Run
12 itest-fabric-atsa - 35707228429.12 448
43.75
GitHub Action Run
13 itest-fabricx-iou - 35707228429.13 480
29.36
GitHub Action Run
14 itest-fabric-twonets - 35707228429.14 448
29.21
GitHub Action Run
15 itest-fabric-iou - 35707228429.15 458
40.47
GitHub Action Run
16 itest-fabricx-simple - 35707228429.16 480
27.94
GitHub Action Run
17 itest-fabric-runtimeconfig - 35707228429.17 458
38.9
GitHub Action Run
18 itest-fabricx-atsa - 35707228429.18 480
30.79
GitHub Action Run
19 itest-fsc-signedpingpong - 35707228429.19 240
31.65
GitHub Action Run
20 itest-fabricx-multiendorsement - 35707228429.20 480
28.59
GitHub Action Run
21 itest-fsc-pingpong - 35707228429.21 245
34.76
GitHub Action Run
22 itest-fabricx-deployment - 35707228429.22 480
28.5
GitHub Action Run
Source Files on build 35707228429