source-academy / js-slang / 35688784234

86%

push

github

feat(conductor): wire up the data visualizer, so draw_data works again (#2089)

* feat(conductor): wire up the data visualizer, so draw_data works again

Closes #2078. All three Conductor evaluators wired visualiseList to a
throw ("draw_data is not supported by this evaluator"), so any §2+
program calling draw_data — which every SICP §2 exercise set reaches
for — failed at runtime.

Following py-slang's PyDataVisualizerRunnerPlugin/toDataVisualizerNode
shape:

- src/conductor/dataVisualizer/toDataVisualizerNode.ts — converts a
  js-slang runtime value into the shared, language-agnostic
  SerializedDataVisualizerNode wire format. Purely mechanical
  dispatch on the value's own JS shape (null -> empty, Array -> array
  node recursing into elements, typeof === 'function' -> function
  node, everything else -> leaf) — no cycle-detection or pair/list
  classification, which stays entirely host-side. A CSE machine
  Closure is itself typeof 'function' (its constructor swaps in
  Closure.prototype on a real Function object), so the same branch
  covers both the transpiler's bare functions and the CSE machine's
  Closures with no instanceof needed.

- src/conductor/dataVisualizer/SourceDataVisualizerRunnerPlugin.ts —
  the two-line adapter BaseDataVisualizerRunnerPlugin expects.

- SourceEvaluator/SourceCseEvaluator/SourceStepperEvaluator now
  register the plugin (§2+ only — SourceCseEvaluator always, since it
  only ever instantiates for §3/§4; the other two gate on chapter),
  call hostLoadPlugin(DATA_VISUALIZER_DIRECTORY_ID), route
  visualiseList through sendDrawing, and call resetRun() at the start
  of every chunk so rows don't accumulate across REPL entries — the
  Conductor-era equivalent of the old frontend's
  DataVisualizer.clearWithData() on every Run press.
  SourceStepperEvaluator's wiring is present for parity but currently
  inert: the stepper has its own, entirely separate symbolic
  draw_data (src/stepper/builtins/lists.ts) that never calls... (continued)

2447 of 2969 branches covered (82.42%)

Branch coverage included in aggregate %.

31 of 32 new or added lines in 7 files covered. (96.88%)

4777 of 5477 relevant lines covered (87.22%)

311897.5 hits per line