source-academy / js-slang / 35677731413

86%

push

github

fix: resolve all 13 tsc --noEmit errors from #2086 (#2088)

None of these were caught by any CI step (yarn build excludes
src/conductor and tests; the evaluator bundler and vitest both run
through esbuild with no type-checking), so they'd accumulated
silently. Fixes, grouped by root cause:

- SourceDataHandler.array_set's two overload signatures were in the
  wrong order: the non-generic, VOID-only signature was declared
  first (making it the only one callers could see), while the actually
  generic, per-element-type signature was the implementation (never
  exposed). Swapped array_set to expose both — the generic overload
  and a VOID-permissive one — the same pattern array_get already used
  correctly. This also let a same-line cast in moduleInterop.ts be
  removed entirely rather than adjusted.

- InvalidArrayCreationError's constructor parameter was named `type`,
  shadowing RuntimeSourceError's own public `type: ErrorType` field
  used for error classification. Renamed to `dataTypeName` — a real
  naming collision, not a suppressible type error.

- rttc.ts's FunctionOfLength<T> used a strict T-element tuple, but
  isFunctionOfLength's runtime check (`f.length === l`) is agnostic to
  a trailing rest parameter (JS's own Function.length already excludes
  it) — so a narrowed value may genuinely accept more than T arguments.
  Swapped in the file's own previously-commented-out rest-args
  definition, which is what the existing test already expected.

- typeUtils.ts's HasCorrectParameters/wrap() overloads were sound;
  three test call sites were themselves wrong — one used `as never`
  where `as any` was needed to avoid a generic-inference artifact
  triggered specifically by testing a non-function value, and two
  passed optArgCount: 1 for a function with zero optional parameters
  (should be 0 — optArgCount counts optional params, not total params).

- Two remaining test-only mismatches (a deliberately-mismatched-type
  call meant to exercise a ru... (continued)

2433 of 2955 branches covered (82.34%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 2 files covered. (100.0%)

4749 of 5451 relevant lines covered (87.12%)

357586.14 hits per line