gladiaio / num2words2 / 35657799232

97%

push

github

fix(ar,hi): reject negative and fractional ordinals (#144)

Ports savoirfairelinux/num2words#672 by @santhreal.

Num2Word_AR.to_ordinal never called verify_ordinal, so a negative
indexed arabicOrdinal backwards and returned a silently wrong word
instead of raising: to_ordinal(-1) was 'ihda' (the feminine one) and
to_ordinal(-100) was 'mi'a' (hundred). It also did number = int(number)
up front, so a fractional value was truncated and read as an ordinal.

Num2Word_HI.to_ordinal_num maps the value character by character through
a Devanagari digit table, so a negative died on the sign with
KeyError "'-'" and a fractional value on the point with KeyError "'.'".

Both now run verify_ordinal first and raise TypeError, matching every
other language. Hindi word ordinals still accept negatives -
to_ordinal(-1) is unchanged - which is what upstream's own test for #672
asserts.

Inf and NaN keep their existing OverflowError and ValueError: Base
writes 'if not int(value) == value', and it is the int() call itself
that raises for those, before any comparison.

Adds regression tests to tests/lang/test_ar.py and tests/lang/test_hi.py
mirroring the upstream ones, and updates the two in-file Rust tests that
pinned the old truncating behaviour.

Adds CHANGELOG.md to carry credit for upstream ports, and points
MANIFEST.in at it (it referenced a CHANGES.rst that does not exist).

Co-authored-by: Jean-Louis Queguiner <jean-louis.queguiner@gmail.com>

1266 of 1422 branches covered (89.03%)

Branch coverage included in aggregate %.

31 of 31 new or added lines in 2 files covered. (100.0%)

24637 of 25795 relevant lines covered (95.51%)

5.73 hits per line