FlexMeasures / flexmeasures / 35604016315

86%

push

github

Cover much more of the UI's JavaScript with tests (#2574)

* Cover much more of the UI's JavaScript with tests

Test the chart data cache and fetch, the replay, date range, data and chart data helpers,
the page-free helpers in ui-utils.js, and the classic scripts flexmeasures.js and map-init.js.

Move the asset tree's layout out of _macros.html into asset-tree.js,
and the flex-context editor's logic out of assets/asset_context.html into flex-context-utils.js,
so that they can be tested too.
Both templates are touched by no open PR.

Fix what the new tests found:
- embed the asset tree, the sensors list and the flex-context on the context page with tojson,
  so a quote in a value no longer stops the flex-context editor from loading,
  and names are shown as text
- import getSensor on the context page, so new commitment prices follow a price sensor's currency
- highlight the current asset, and recognise the "Add asset" node, by id rather than by name
- keep the plus sign of a UTC offset in encodeUrlQuery
- translate Python representations properly in processResourceRawJSON, and accept objects

Closes #2452

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: F.N. Claessen <felix@seita.nl>

* Link the changelog entries to PR #2574

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: F.N. Claessen <felix@seita.nl>

* Embed and render user-supplied text safely on every asset and sensor page

Embed data in scripts with tojson rather than as Python or JSON strings marked safe:
the available units, the asset's flex-model on its properties page, and the chart options,
whose download file name carries the asset's name.
Escape names, units, graph titles and flex-model values wherever they are built into markup,
with a shared escapeHtml in ui-utils.js,
and drop Sensor._ui_unit, which handed the unit to templates as markup.
Correct the UI guidelines, which recommended both patterns.

Co-Authored-By: Claude Opus 5 <noreply@anthropi... (continued)

2 of 2 new or added lines in 1 file covered. (100.0%)

19504 of 22757 relevant lines covered (85.71%)

0.86 hits per line