zentralopensource / zentral / 35601526096

91%

Build Type

push

github

Committed by np5

Commit Message

santa: A list of the machines, and a page for each one

Santa > Machines gives one row for each machine, its current enrollment, with
filters on the configuration, the age of the last synchronization, the client
mode, the Santa version and the synchronization state. The filters apply to the
current rows only, so a stale row never puts a machine in a page.

The page of a machine answers "what does this machine get, and why". It gives
what the machine reported at its last preflight, the inputs of the scope -
serial number, primary user and tags - the client mode and the two path regexes
Zentral resolved for it, and its enrollments. For each scoped client mode and
each scoped path regex, it gives the field that decided and what became of the
entry: it wins, it loses to a narrower one, or the machine is out of its scope.

The mode and the patterns come from get_sync_server_config(), the method that
answers the preflight, so the page cannot disagree with what the machine gets.
It costs a second read of the entries: the page also reads them through
explain_for_machine(), which keeps the entries that are out and names the field
that put them out. The preflight does not pay for that second expression.

The existing viewEnrolledMachine PBAC action opens both pages. The tables only
give the entries the user may view, and the resolution still reads every entry,
so a user who may not view an entry sees the mode of the machine without its
name.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Coverage Stats

165 of 165 new or added lines in 7 files covered. (100.0%)

20 existing lines in 3 files now uncovered.

52521 of 57806 relevant lines covered (90.86%)

0.91 hits per line