elixir-mint / mint / 8f1e396d6b8ab0b7f5e125993fa156543331602a-PR-508

89%

main: 91%

Build Type

Pull #508

github

Committed by ericmj

Commit Message

Apply the acknowledged HTTP/2 header table size to the decoding table

put_settings/2 accepted :header_table_size but the handler for the
server's SETTINGS ACK didn't know the setting and raised a RuntimeError
out of stream/2. The setting is now recorded and the HPACK decoding
table's permitted maximum follows it.

That maximum is a limit rather than the size of the table. The table's
own maximum belongs to the server's encoder, which declares it with a
dynamic table size update (RFC 7541 4.2), so HPAX.resize/2, which moves
both, would keep entries the server had evicted and decode an indexed
reference to one of them as a stale header.
HPAX.protocol_resize/2 moves only the limit and follows it down when it
drops below the size the encoder declared. After a reduction the server
has to declare its new size at the start of the next field block, which
RFC 9113 4.3.1 requires the client to enforce, so a block that doesn't
is a connection error with COMPRESSION_ERROR.

Pull Request Pull Request #508: DO NOT MERGE: Apply the acknowledged HTTP/2 header table size to the decoding table

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

40 existing lines in 1 file now uncovered.

1520 of 1718 relevant lines covered (88.47%)

555.56 hits per line