adobe / spectrum-web-components / 35586840942

96%

push

github

fix(picker): sync controller open state on external close (#6749)

* fix(picker): sync controller open state on external close

When the overlay closed externally (e.g. tapping outside the mobile Tray)
with preventNextToggle === 'no', handleBeforetoggle set the host's open to
false but left the interaction controller's open state stale at true. On the
next tap MobileController set preventNextToggle = 'yes' and skipped toggle(),
so the Tray never reopened. Sync strategy.open on this branch, matching the
sibling branch above.

Fixes https://github.com/adobe/spectrum-web-components/issues/6678

* test(action-menu): add real end-to-end mobile Tray reopen test

Replace the synthetic beforetoggle test (which drove the handler directly
and did not exercise the real close path) with an end-to-end test that
opens the Tray by tapping the button, dismisses it by tapping outside, and
verifies a second tap reopens it. Reproduces the outside-tap close branch
where host.open is still true at beforetoggle; fails without the Picker
controller-state sync fix (on Firefox) and passes with it on all browsers.

6121 of 6564 branches covered (93.25%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

38550 of 39829 relevant lines covered (96.79%)

460.88 hits per line