int-brain-lab / ibleatools / 35543598344
62%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 41
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 60.504% (+0.4%) from 60.133%
35543598344

push

github

web-flow 
Recover waveform amplitudes in Volts, normalize spike_count to a rate (#124)

* Recover waveform amplitudes in Volts, normalize spike_count to a rate

DARTsort z-scores AP data by per-channel RMS for its detection threshold;
that scaling was never un-applied, so ptp/peak/trough/tip/slope amplitudes
and the waveform snippets came out in dimensionless channel-RMS units
instead of Volts. dart_subtraction_numpy now rescales them back to Volts
using the same per-channel RMS (alpha stays in DARTsort's native units,
since it's fit jointly across channels each normalised by a different RMS).

spike_count was also a raw per-snippet count, not comparable across
snippets of different durations (e.g. the 5s AP default). It's now a rate
(spikes/s), independent of snippet length.

* Extract ModelSpikeSharedFeatures to de-duplicate spike-shape fields

ModelSpikeFeatures and ModelSpikeShapeFeatures redeclared the same 8
fields (tip_val, alpha_mean/std, polarity, spike_count, the 3 slopes),
which is exactly why the amplitude/rate unit fixes had to touch both.
Move them to a shared base class both inherit from; standardizes their
descriptions along the way. Column sets/order for both schemas are
unchanged, but _remap_waveform_shape_arrays' dict now matches
ModelSpikeShapeFeatures' new declaration order (inherited fields first).

* Set waveforms TV-denoise fac to 3

DEFAULT_FAC["waveforms"] was left at 5 from the bracketing analysis in
the per-feature-group fac PR; should be 3.

* Changelog update and version bumps

---------

Co-authored-by: Pranav Rai <rpranaviitk@gmail.com>

2739 of 4527 relevant lines covered (60.5%)

0.61 hits per line

Coverage Regressions

Lines Coverage ∆ File
131
54.65
2.13% feature_computation.py
47
89.06
0.62% features.py
Jobs
ID Job ID Ran Files Coverage
1 35543598344.1 41
60.5
GitHub Action Run
Source Files on build 35543598344