decentraland / archipelago-workers / 35532871769

93%

main: 93%

Pull #136

github

fix: count forced closes and share the socket close protocol

Address the review on #136.

- Count every socket closed for a dropped island_changed in
  dcl_ws_connector_island_changed_dropped_close_total, before the close.
- Move safeEndWebSocket to src/logic/websocket.ts and use it from the
  island feed too; name the µWebSockets send results and the 1013 close
  the tests re-assert, and say why handshake frames accept SENT only.
- Make the route's maxBackpressure explicit and configurable
  (WS_MAX_BACKPRESSURE_BYTES, µWebSockets' 64 KiB default) and document
  that every frame must fit under it.
- Give the end-to-end flood an explicit hook timeout, size its frames off
  that limit and let it run until the drop is observed; add the
  fresh-ephemeral-key recovery shape and the forced-close metric check.
- Settle the in-memory NATS spec on a macrotask instead of 50 ms sleeps.

127 of 152 branches covered (83.55%)

Branch coverage included in aggregate %.

46 of 46 new or added lines in 3 files covered. (100.0%)

643 of 672 relevant lines covered (95.68%)

22.06 hits per line