ruby-grape / grape / 35532696661

99%

master: 100%

Pull #2977

github

Copy the query params only when the params builder hands them back

Since #2972 a request with no body builds its params from `self.GET`, the
query hash Rack memoizes in the env, rather than from the copy the merge in
`Rack::Request#params` used to hand over. The copy was reinstated with an
unconditional `dup`, so that the writes which follow -- routing args,
coercions, defaults -- cannot reach the env.

Every params builder Grape ships constructs a new object, so that `dup` is
allocated and thrown away on every such request. Only a builder that returns
its argument needs it, and an identity comparison says so for the price of a
pointer compare.

Over the 6400-request mix of a real API, counting every allocation and not
just Grape's: 185.0 objects per request before, 184.4 after, against 187.0
before #2972.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

1466 of 1523 branches covered (96.26%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

4330 of 4330 relevant lines covered (100.0%)

28755.04 hits per line