gladiaio / num2words2 / 35507441595

97%

push

github

fix(ti): render Tigrinya in Ge'ez script and use real Tigrinya ordinals (#134)

* fix(ti): render Tigrinya in Ge'ez script instead of Latin transliteration

Upstream `lang_TI.py` spells every Tigrinya numeral in Latin
transliteration ("ḥade", "mi'ti", "shiḥ"). Tigrinya is written in Ge'ez,
and the sibling Ethiopic language in this crate (lang_am.rs, Amharic)
already emits Ge'ez, so the transliteration was an upstream accident
rather than a choice.

- Respell the ONES/TENS tables, ZERO_WORD, HUNDRED, THOUSAND, MILLION,
  NEGWORD, POINTWORD, the AND connector and the ordinal suffix in Ge'ez
- Respell the four CURRENCY_FORMS entries (ETB/ERN/USD/EUR) and the
  exclude_title list
- Re-spell the frozen-corpus fixtures in-file to match; every assertion
  they make other than the spelling is unchanged
- Update tests/lang/test_new_26_languages.py's "ti" basics fixture
- Document the divergence in the module header

This is a lexicon change only. The ported structure is untouched: the
composition rules, the `> 1` multiplier guards, the billion cliff, the
missing verify_ordinal call and the ETB currency fallback all still
reproduce upstream bug for bug.

It is a knowing departure from byte-for-byte upstream fidelity, and the
only one in this module.

* fix(ti): use real Tigrinya ordinals instead of a glued suffix

Upstream builds every ordinal as `to_cardinal(n) + "ay"`, which produces
the non-word "ሓደኣይ" for 1st. Tigrinya has two arms: 1-10 are suppletive,
and 11 up take the free-standing word መበል before the plain cardinal.

- Add ORDINAL_IRREGULARS, the suppletive masculine forms for 1-10
  (ቀዳማይ, ካልኣይ, ሳልሳይ, …), and ORDINAL_PREFIX ("መበል ") for 11 and above
- Apply the same two arms to the digit form: ይ suffixed to the digit up
  to 10 ("1ይ", "10ይ"), then the prefix on the bare digit ("መበል 11").
  This is the formal/textbook convention; the colloquial one extends ይ
  to every number and is a one-line switch, documented in place
- Change the digit suffix from ... (continued)

1262 of 1418 branches covered (89.0%)

Branch coverage included in aggregate %.

36 of 43 new or added lines in 1 file covered. (83.72%)

24606 of 25764 relevant lines covered (95.51%)

5.73 hits per line