umputun / feed-master / 35482550641

75%

master: 75%

Pull #179

github

fix: guard CleanText against a limit below the reserved suffix

CleanText sliced []rune(res)[:maximum-4] with no lower bound, so any maximum
under 4 indexed negative and panicked. It is reachable from remote feed content:
getMessageHTML passes 1024-len(header+footer) to CropText, and header is built
from the feed item's own title and link, neither of which is bounded. A 1000
character title panics with slice bounds out of range [:-47] through
telegram.go:196 and telegram.go:217. Nothing recovers under app/, so one verbose
feed item stops the daemon.

A limit below 4 now truncates without the " ..." suffix instead of indexing
negative, and a limit of zero or less returns empty. TestCleanText only ever
passed max 10, which is why this stood; it now covers 3, 1, 0 and a negative,
and TestTruncatedMessageLongTitle pins the path from a long title.

Related to #174

10 of 10 new or added lines in 1 file covered. (100.0%)

1475 of 1974 relevant lines covered (74.72%)

10.72 hits per line