ruby-grape / grape / 35464901001

99%

master: 99%

Pull #2967

github

Hand a Proc passed as the last middleware argument to the middleware

The middleware DSL recorded a registration as [operation, *args] and
appended the block only when one was given, so Stack#merge_with told the
block apart by its class: whatever Proc came last was popped and passed
as the block. A callable handed to a middleware as its last argument,
as in `use SomeMiddleware, ->(env) { ... }`, was taken for the block
instead, and the middleware was built without it, raising ArgumentError
when the stack was built. `insert_before` and `insert_after` did the
same.

Every registration now ends in its block, nil when none was given, and
merge_with always takes the last element as the block. That changes the
entries `API.middleware` returns, hence the UPGRADING note.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

1445 of 1501 branches covered (96.27%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 2 files covered. (100.0%)

4300 of 4300 relevant lines covered (100.0%)

28830.41 hits per line