ruby-grape / grape / 35455284877

100%

push

github

Reject what a collection with multiple member types cannot coerce (#2955)

A param declared as `type: Array[Integer, String]` -- or with such a
collection among its `types:`, as in the README's
`types: [Integer, String, Array[Integer, String]]` -- is coerced by
VariantCollectionCoercer, which checked neither its input nor its output:

- a value that is not an Array returned nil rather than an InvalidValue,
  so CoerceValidator wrote nil over it and `requires :ids, type:
  Array[Integer, String]` let `ids=x` through as nil;
- each member went through the member coercer and the results were
  returned as they came, so a member none of the types accepts reached the
  endpoint as a Grape::Validations::Types::InvalidValue object.

Array[Integer] answers 400 to both, and now so does a collection with
multiple member types. nil and '' still coerce to nil, as specs pin.

The coercion method, when one is given, was never called for anything but
an Array: a `coerce_with` that splits a String into the collection saw
nothing and the param came out nil. It is now handed the value whatever it
is, as MultipleTypeCoercer hands it for `types:`.

UPGRADING covers both, since each turns a request that used to pass into a
400.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

1435 of 1491 branches covered (96.24%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 1 file covered. (100.0%)

4279 of 4279 relevant lines covered (100.0%)

28468.36 hits per line