polserver / polserver / 35422775927

82%

push

github

Add damage_increase and damage_increase_mod to characters and items (#970)

Every other AOS property in this family already existed on UObject -
spell_damage_increase, swing_speed_increase, hit_chance, luck,
defence_increase, the two attack range increases. Damage Increase was the
one that was never added, and the gap showed in two places: scripts had no
member to read or set, and send_full_statmsg skipped the protocol's Damage
Increase slot outright, so every client was told the value was zero.

The new property is a plain sibling of spell_damage_increase and carries
nothing special: a ValueModPack on UObject, an orig_ copy on NPC, the
DamageIncrease and DamageIncreaseMod keys in itemdesc.cfg and NPC templates,
the value half saved by Item and the mod half by UObject, summed onto the
wearer by updateEquipableProperties and zeroed by resetEquipableProperties.
The status bar now sends the real total in the slot it was skipping. The
packet length is computed from the write offset, so nothing else moved.

The core stores and displays the value and does not apply it to damage.
That matches the rest of the family - only swing_speed_increase and the
attack range increases are consumed by the core, and spell_damage_increase
has never been read by any damage path. What a percentage means is the
shard's business.

weapon.dmg_mod is deliberately left alone. It is a flat s16 added to the
rolled dice in UWeapon::get_random_damage and reported through
min_/max_weapon_damage, while damage_increase is a percentage shown in the
status bar; folding one into the other would report a flat damage number to
the client as a percentage and count it twice. A weapon that should grant
both simply carries its own DamageIncrease, which the existing equipment
accumulation already picks up.

The property ids are appended rather than inserted. DynPropTypes values are
in-memory bitset indices and never persisted, but MemberID is written into
compiled .ecl bytecode, so the two new me... (continued)

53 of 58 new or added lines in 11 files covered. (91.38%)

59732 of 73051 relevant lines covered (81.77%)

1603409.6 hits per line