eclipse-aascw / aas-core-codegen / 35393723831

90%

Build Type

push

github

Committed by web-flow

Commit Message

Type runtime IDs of intermediate representation (#731)

The types of the intermediate representation are compared by identity and
not by value -- two properties which agree on the name and on the type
annotation are two different properties -- so everything which has to key
on one of them keys on ``id(.)``. There were some thirty such containers,
and every one of them was a bare ``int``:

    literal_id_set: Final[FrozenSet[int]]
    _property_id_set: FrozenSet[int]
    _concrete_descendant_id_set: FrozenSet[int]
    ids_of_types_reaching_a_number: Set[int]

Nothing therefore stopped an ID of one kind from being looked up in a set
of another. ``runtime_id`` now carries the kind of the object over into
the type of its ID:

    RuntimeId = NewType("RuntimeId", int)
    IdOfOurType = NewType("IdOfOurType", RuntimeId)
    IdOfClass = NewType("IdOfClass", IdOfOurType)
    IdOfProperty = NewType("IdOfProperty", RuntimeId)
    ...

    @overload
    def runtime_id(something: "Class") -> IdOfClass: ...
    @overload
    def runtime_id(something: "Property") -> IdOfProperty: ...
    ...
    def runtime_id(something: object) -> RuntimeId:
        return RuntimeId(id(something))

A ``NewType`` over a ``NewType`` gives the hierarchy its second level: a
class *is* one of our types, so a class ID goes wherever an
``IdOfOurType`` is expected -- into ``ids_of_types_reaching_a_number``,
which holds the IDs of classes and of named unions alike -- while a
container of class IDs refuses the ID of an enumeration. A ``FrozenSet``
is covariant, so no call site had to widen anything by hand.

The overloads are spelled with forward references, which lets the whole
region sit at the top of ``_types.py``, where it is read before anything
which uses it, although ``Class`` and ``OurType`` are defined a thousand
lines below.

``id(self)`` inside a ``__repr__`` stays as it is: it formats an address
and keys nothing. So do ``common.assert_union_of_descendants_exhaustive``
and the di... (continued)

Coverage Stats

140 of 145 new or added lines in 19 files covered. (96.55%)

2 existing lines in 2 files now uncovered.

35010 of 40759 relevant lines covered (85.9%)

2.58 hits per line