decentraland / archipelago-workers / 35390789484

93%

main: 93%

Pull #135

github

fix: keep a dropped island_changed out of the dedup ledger

`forward()` recorded the island and timestamp before calling `ws.send`, and never
rolled them back when the send failed. A frame uWS dropped at the backpressure
limit therefore suppressed any re-delivery of the same island to that socket for
the rest of the dedup window, and that suppression was counted as a duplicate, so
the peer was left with no room while the metrics read as healthy.

The ledger is now written only once the frame has actually been handed to the
peer. Nothing re-publishes `island_changed` on a timer and the only re-announce
trigger is a fresh `peer.{address}.connect` at handshake, so the suppressed
message was the sole means of repairing that peer.

Also stops treating a `send` result of 0 as a failure: uWS returns 0 for a frame
queued behind backpressure that will drain, and 2 only for one it discarded. The
warning fired on both, overstating real losses in the logs.

The dedup key stays the island alone, deliberately. The client reads only
`connStr` and treats any new one as a room change, so re-handing a healthy peer a
fresh token for the room it already occupies would make it reconnect under the
same identity and be evicted by LiveKit.

124 of 149 branches covered (83.22%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

630 of 659 relevant lines covered (95.6%)

12.28 hits per line