CyclopsMC / IntegratedTunnels / 35383930577

71%

master-1.21-lts: 71%

Pull #389

github

Expose the network to the Player Simulator without copying items

The first implementation copied network items into the simulated player's
inventory before each click, and worked out afterwards what had been
consumed. That capped the reachable items at the inventory size, so items
sitting behind the first ~35 network items were never available, and the
after-the-fact accounting could not be trusted when the network changed
during the click.

The simulated player now gets an inventory that exposes the network as
additional slots. The network is only iterated when something actually
reads those slots, and items are only really taken out of the network at
the moment they are taken out of the inventory, so no item is ever handed
out that was not removed from the network first. Anything that is not
consumed is inserted back into the network after the click, like the
clicked-with item already was.

Player#getProjectile reads the inventory field directly, so the inventory
object itself is replaced, which needs an access transformer. Its
getProjectile is overridden to take the projectile out of the network
before handing it to the weapon.

Also adds a game test where the arrows sit behind more items than fit in a
player inventory, which fails with any such cap in place.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M33ptG2Reko7AGmxBjZQYj

711 of 1830 branches covered (38.85%)

Branch coverage included in aggregate %.

6245 of 7893 relevant lines covered (79.12%)

4.13 hits per line