kobotoolbox / kpi / 35368358556

83%

master: 76%

push

github

fix(frontend): drop audit column and place start-geopoint with metadata DEV-1480 (#7603)

### 📣 Summary

The `audit` metadata question is no longer a column in Data Table nor a
row in a single submission, and the start geopoint column now sits with
the rest of the metadata at the end of the table.

### 💭 Notes

Follow-up to #7389 on two QA findings: `audit` still showed up in the
Single Submission modal (step 11), and the table column order didn't
match the one the preview described (step 4) — both caused by the same
`audit` column that had no business being there.

Changes here:

- **`tableConstants.ts`**
  - `EXCLUDED_COLUMNS` gains `meta/audit`
- The audit question of the survey is excluded separately, by row type,
via the new `EXCLUDED_ROW_TYPES`
- `isMetadataKey()` applies the same reasoning to `LAST_COLUMNS_ORDER`
and to the front-moved `start`/`end`
  - `METADATA_COLUMN_LABELS` loses its `audit` entry, now unreachable
- `LAST_COLUMNS_ORDER` gains `start-geopoint`. It was the one meta
question missing from that list
- Exports are deliberately untouched: `ProjectExportsCreator` builds its
own wider list and doesn't apply `EXCLUDED_COLUMNS`.
- **tests** — 6 new cases

### 👀 Preview steps

1. ℹ️ have a project, open it in the form builder, go to Layout &
Settings → Metadata, tick `start time`, `end time`, `today`, `username`,
`device ID`, `phone number`, `audit` and `start geopoint early`, then
save and deploy
2. ℹ️ have at least one submission
3. go to Project → Data → Table and scroll right
4. 🔴 [on main] notice an `audit` column holding a file name that leads
nowhere, and a start geopoint column next to it
5. 🟢 [on PR] notice `audit` is gone entirely, and the last columns read:
username, device ID, phone number, today, start geopoint, then
`__version__`, `_id`, `_uuid`, submission time, submitted by, rootUuid
6. click "hide fields"
7. 🟢 notice `audit` isn't on offer there either
8. back in the table, open a single submission and scroll to the
me... (continued)

10252 of 13582 branches covered (75.48%)

32785 of 39525 relevant lines covered (82.95%)

5.51 hits per line