kubernetes-sigs / external-dns / 35341630410
82%

DEFAULT BRANCH: master
Ran
Jobs 2
Files 158
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 81.942% (+0.02%) from 81.925%
35341630410

push

github

web-flow 
fix(cloudflare): normalize provider-specific property names at ingestion (#6731)

* fix(cloudflare): normalize provider-specific property names at ingestion

Cloudflare property names were built from the annotation that sets them
(AnnotationKeyPrefix + "cloudflare-proxied"), so they depended on
--annotation-prefix. DNSEndpoint authors write these names by hand in
spec.endpoints[].providerSpecific, which made a manifest depend on the
controller's flags and broke when the default prefix changed in v0.22.0.
The legacy annotation prefix flag cannot help there: it rewrites
metadata.annotations, not spec fields.

Cloudflare properties are now plain constants in the "provider/attribute"
form every other provider already uses (cloudflare/proxied, cloudflare/tags,
...). A source wrapper step rewrites the old annotation-form names, with any
prefix, onto the canonical ones and warns once per name, so existing
DNSEndpoints keep working. This also removes the cloudflare special case from
RetainProviderProperties, which until now retained every other provider's
properties too.

* comment review

* Update source/annotations/provider_specific.go

Co-authored-by: vflaux <38909103+vflaux@users.noreply.github.com>

* fix(annotations): add missing internal/sets import

* fix(cloudflare): scope legacy name normalization to the cloudflare provider

Normalizing for every provider rewrote "webhook/cloudflare-*" properties
to "cloudflare/*", which RetainProviderProperties then dropped for webhook
providers. Gate the rewrite on provider == cloudflare.

Key the one-time deprecation warning on the canonical name so the map is
bounded by the number of known properties, and log each rewrite at debug.

---------

Co-authored-by: vflaux <38909103+vflaux@users.noreply.github.com>

15660 of 19111 relevant lines covered (81.94%)

1439.8 hits per line

Coverage Regressions

Lines Coverage ∆ File
2
97.8
-2.2% annotations/provider_specific.go
Jobs
ID Job ID Ran Files Coverage
1 run-ubuntu-latest - 35341630410.1 158
81.94
GitHub Action Run
2 run-macos-latest - 35341630410.2 158
81.94
GitHub Action Run
Source Files on build 35341630410