35338998901
82%

Ran 18 Sep 2026 11:23AM UTC

Jobs 2

Files 158

Run time 1min

Badge

Embed ▾

Committed 18 Sep 2026 11:18AM UTC coverage: 81.925% (-0.002%) from 81.927%

Build # 35338998901

Build Type

push

github

Committed by

web-flow

Commit Message

fix(source/crd): apply the annotation filter outside the cache transform (#6730)

* fix(source/crd): apply the annotation filter outside the cache transform

The crd source filtered on --annotation-filter inside the informer cache
transform, which returned nil for a non-matching DNSEndpoint. A transform
cannot drop an object: since client-go 1.36 enables AtomicFIFO, the initial
LIST arrives as a single ReplacedAll delta, so one nil discards the whole
batch and the cache ends up empty, matching DNSEndpoints included. The
source then reports no endpoints and --policy=sync deletes every record it
owns, without a log line.

Endpoints() now applies the selector at read time, like every other source,
and the transform never returns nil. A regression test drives NewCRDSource
against a fake API server so the informer and its cache run as in a cluster;
the existing fakes are populated directly and cannot catch this.

* self-review

* test(source/crd): assert instead of require in the fake API server handler

writeJSON runs in the httptest server goroutine, where require's FailNow only
kills that goroutine: the client gets a truncated response and the test keeps
running until the cache sync times out, far from the real error. assert reports
through Errorf, which is safe from any goroutine.

Coverage Stats

15637 of 19087 relevant lines covered (81.92%)

1441.2 hits per line

Coverage Regressions

Lines	Coverage	∆	File
16	87.88	0.48%	crd.go
10	87.8	-0.96%	informers/transformers.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	run-ubuntu-latest - 35338998901.1	18 Sep 2026 11:24AM UTC	158	81.92	GitHub Action Run
2	run-macos-latest - 35338998901.2	18 Sep 2026 11:23AM UTC	158	81.92	GitHub Action Run

kubernetes-sigs / external-dns / 35338998901
82%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 35338998901

kubernetes-sigs / external-dns / 35338998901 82%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 35338998901

kubernetes-sigs / external-dns / 35338998901
82%

README BADGES
x