ruby-grape / grape / 35336214906

99%

push

github

Keep every mount of an API mounted twice when the mounts are refreshed (#2956)

Every DSL call an API class makes after a `mount` refreshes that mount: the
recorded step is replayed as refresh_mounted_api, which drops the endpoints
the mount created and mounts the app again, so it picks up what was declared
since. drop_endpoints_mounted_for picked those endpoints by the mounted app's
base API alone, so an API mounted twice lost one mount to the other's
refresh:

    mount Votes => '/posts'
    mount Votes => '/comments'
    get('/other') { ... }       # /posts/votes is now a 404

The refresh of the first mount dropped both endpoints and put back
/posts; the refresh of the second dropped /posts again and put back
/comments. The same happens to a mount inside a namespace, whose step is
the `namespace` call rather than a `mount`, so it is never refreshed:

    mount Votes, with: { ... }
    namespace(:comments) { mount Votes, with: { ... } }  # dropped

The first shape has lost a mount since mount refreshes existed; the second
since #2871, before which the refresh dropped nothing and left the first
mount doubled up next to the second.

An endpoint is now dropped only where it was mounted at the refreshed
path, in the current namespace. Endpoint#path exposes the path an endpoint
was declared at for that, next to #mounted_app, since the config holding it
is protected.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

1429 of 1483 branches covered (96.36%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 2 files covered. (100.0%)

4271 of 4271 relevant lines covered (100.0%)

28598.95 hits per line