ruby-grape / grape / 35334563378

99%

master: 99%

Pull #2953

github

Keep a String error message's status when the route names a failure entity

ErrorFormatter::Base#present applies the entity a route's failure codes
name for the response status to whatever error! was given. An entity
exposing attributes cannot read any off a String, so error!('Unauthorized',
401) under `failure: [[401, 'Unauthorized', API::Error]]` raised while
rendering, and the failsafe answered 500 in place of the 401.

That has been true of the `failure` block method and the `http_codes:`
keyword for as long as they presented errors. #2949 made the `failure:`
keyword present too -- the spelling grape-swagger's README recommends -- so
on master an API that documents its 401 that way and calls error! with a
String turns every 401 into a 500.

The failure entities document a structured error body, and every README
example hands error! a Hash, so a String message is now left to
#wrap_message, which renders it the way it renders without an entity. A
Hash or an object is presented as before, and `with:` and a class's own
Entity are untouched.

An entity written to take the String itself is no longer handed one;
UPGRADING shows moving it to a Hash message.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

1428 of 1483 branches covered (96.29%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

4266 of 4266 relevant lines covered (100.0%)

28550.52 hits per line