safe-global / safe-decoder-service / 35327124152

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix: Skip an ABI function that cannot be indexed (#351)

* fix: Skip an ABI function that cannot be indexed

Rows in the abi table come from third party sources, so an element can be
missing the fields a selector needs. selectors_from_abis read fn_abi["type"]
and let the exception out, so one bad row aborted the whole batch. At startup
that reached the background loader in main.py, which retries forever, so
/health/ready stayed at 503 and the pod never joined the Service. The reload
path already tolerated a bad row since PLA-1954, startup did not.

The guard is now per element and catches everything. Which exception a
malformed element raises is a detail of the libraries that parse it, and the
invariant is that no single element can leave the decoder without a selector
map. Per element also means losing one method instead of every function of a
contract, which is what a per row guard would drop.

A missing type now means "function", as the ABI spec says. It has to be filled
in because function_abi_to_4byte_selector reads the key and raises without it.
Elements with no name are left out: abi_to_signature invents a signature for
them, and decoding one raises KeyError later, outside DataDecoderException, so
the request returns 500.

The per row handler in load_new_abis is gone. selectors_from_abis is the single
funnel for startup, reload and the per address lookup, so the guard belongs
there and only there.

The malformed_abi mock was [{"name": "buyDroid"}], which is now a valid ABI, so
it moves to a tuple input without components.

Refs PLA-2002

* Update app/services/data_decoder.py

Co-authored-by: Felipe Alvarado <felipe@safe.global>

* style: Format the warning added from the review suggestion

---------

Co-authored-by: Felipe Alvarado <felipe@safe.global>

Coverage Stats

20 of 20 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

1421 of 1561 relevant lines covered (91.03%)

0.91 hits per line