safe-global / safe-decoder-service / 35231585975

91%

push

github

fix: Keep the ABI reload cursor consistent when a reload fails (#350)

`load_new_abis` read the latest ABI id into `last_abi_id` before streaming and
applying the rows. Any failure in between (connection drop, bad ABI json) left
the cursor past rows that were never applied, so those ABIs were skipped for the
whole life of the process. Only a restart recovered them.

The cursor is now written after every fetched ABI was applied, so a reload that
dies halfway is retried from the same id.

A single ABI that cannot be turned into selectors is dropped and logged instead
of aborting the reload. If it aborted, that row would stop the cursor on every
later reload and no new ABI would ever load again. The catch is limited to the
errors a malformed `abi_json` produces, so a real failure still aborts and keeps
the cursor back.

The cursor is no longer written on the "no new ABIs" path. There it could only
stay the same or move backwards when rows were deleted, which contradicts the
monotonic cursor the reload relies on.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

12 of 12 new or added lines in 2 files covered. (100.0%)

1410 of 1550 relevant lines covered (90.97%)

0.91 hits per line