eclipse-aascw / aas-core-codegen / 35319779908

90%

push

github

Reject non-finite floats in the C# JSON (#718)

JSON knows neither an infinity nor a not-a-number. Up to now the C#
jsonization handed both to `Nodes.JsonValue.Create`, which takes them
without a word; `System.Text.Json` only refuses them much later, when
the caller writes the document out, and says nothing about where in
the instance the offending value sat.

Unlike Java, C# had no serialization error path to mirror -- its XML
serialization can not fail either -- so this builds one in the shape
which lets a path be assembled while the stack unwinds: an internal
`SerializationFailure` carries a `Reporting.Error`, and
`Serialize.ToJsonObject` renders it once into a public
`SerializationException` with `Path` and `Cause`. That public exception
is deliberately shaped like the `Jsonization.Exception` which the
de-serialization already throws, so that the two directions read alike.

`ToJsonValue` stays an overload set, and does not gain distinct names
the way the Java conversions did. The overloads are load-bearing here:
they exist so that a *method group* of ours can be converted to
a `Serializer<T>`, which `Nodes.JsonValue.Create` can not be, being
a generic method with an optional second parameter (CS1503).
`ToJsonValue(double)` therefore moves out of the composed-only helpers
and is emitted next to `ToJsonValue(long)`.

`ToJsonValue(long)` no longer round-trips through a double to decide.
That check admitted 9007199254740994, which happens to be exactly
representable, where C++ and Go refuse it; the range is now spelled the
same way in every target.

The index needs no gating in C#: `SerializeList` and `SerializeTupleN`
are shared generic combinators which already know the position, so
the `try` sits in them once instead of being generated per item type,
and costs nothing on the happy path. Only the recording of a property
is gated, by `intermediate.reaches_a_number`.

`DoubleFrom` rejects a non-finite value as well. A conformant parser can
never produ... (continued)

43 of 43 new or added lines in 2 files covered. (100.0%)

34758 of 40505 relevant lines covered (85.81%)

2.57 hits per line