eclipse-aascw / aas-core-codegen / 35298544509

90%

push

github

Reject non-finite floats in the Java JSON (#717)

JSON knows neither an infinity nor a not-a-number. Up to now the Java
jsonization handed both to Jackson, which writes them out as the quoted
strings `"NaN"` and `"Infinity"` -- valid JSON, but no longer a number,
and no parser reads them back as one.

`doubleToJsonNode` refuses a non-finite value. `longToJsonNode` -- which
used to be `toJsonNode` -- refuses an integer outside
[-2^53 + 1, 2^53 - 1], and no longer throws a bare
`IllegalArgumentException` with no path. Mind that this also *changes*
which integers are refused: the previous round-trip check,
`(long)((double)that) != that`, admitted 9007199254740994, as that one
happens to be exactly representable, where C++ and Go refuse it. The
range is now spelled the same way in every target.

`tryDoubleFrom` asks for a number, and no longer for a floating-point
number: JSON has a single number type, so `3` is every bit as good
a double as `3.0` is, and every other SDK reads it as one. It rejects
a non-finite value as well -- Jackson parses those when
`JsonReadFeature.ALLOW_NON_NUMERIC_NUMBERS` is enabled, and the caller
hands us an already-parsed `JsonNode` in any case.

64 of 64 new or added lines in 2 files covered. (100.0%)

34719 of 40466 relevant lines covered (85.8%)

2.57 hits per line