eclipse-aascw / aas-core-codegen / 35287206928

90%

push

github

Reject non-finite floats in the C++ JSON (#713)

JSON knows neither an infinity nor a not-a-number. Up to now the C++
jsonization silently handed both to nlohmann, which writes them out as
``null``, so an infinite or not-a-number property left the SDK as a JSON
document that no longer said what the instance held.

``SerializeDouble`` now returns the very same
``(optional<json>, optional<SerializationError>)`` pair as
``SerializeInt64``, and refuses a non-finite value.

``DeserializeDouble`` rejects a non-finite value as well. A conformant
parser can never produce one, but the caller gives us an
``nlohmann::json`` which may have been constructed programmatically.

We also include ``<cmath>`` explicitly. ``std::modf`` in
``DeserializeInt64`` has been relying on it arriving transitively through
``nlohmann/json.hpp``.

The tests go into the existing test of the JSON de/serialization of
the concrete classes, driven by a new ``intermediate.numeric_places``.
That query lists the places where a number unrepresentable in JSON can
sit -- a property, a list item and a tuple item -- so that the same
tests can be generated for the other targets as well. The list case puts
the bad value at the index 1 on purpose: a serializer which always
reports the index 0 has to fail the test.

84 of 87 new or added lines in 5 files covered. (96.55%)

34442 of 40185 relevant lines covered (85.71%)

2.57 hits per line