ruby-grape / grape / 35255936320

99%

master: 99%

Pull #2948

github

Speed up path-versioned requests and error responses

Three steps every request pays for, none of which had anything left to do
by the time they ran.

A path-versioned request is matched by a route whose pattern captures the
version, so by the time the versioner runs, the answer is already in the
routing args. `Versioner::Path` recorded it from inside `#before`, which
`Middleware::Base#call` reaches through a per-request copy of the
middleware -- made so that `#before` and `#after` can keep request state on
it. There is no state to keep here: the routed request now records the
version and calls the app, and a request the router did not match (the
greedy routes behind 405 and auto-OPTIONS, or the middleware used on its
own) still goes through the copy and parses the path as before.

`Middleware::Error#call!` returned the app's response from inside the
block it passes to `Kernel#catch`. A `return` from there leaves the method
the way a `throw` does, allocating for the unwind, on every request that
did not fail. It now records whether the app answered and reads that
after the `catch`.

`DSL::Entity#entity_class_for_obj` asked for the `represent` registrations
once per lookup, and it does two: the object's class, then its element
class. Resolving them walks every scope up to the API's root, and a Hash
answers `#first`, so `error!({ ... })` and `present hash` walked it twice.
It is read once and handed to both.

Measured against master, three interleaved rounds, no JIT / YJIT: a
path-versioned JSON GET +16.1% / +13.5%, the same GET carrying six headers
+12.1% / +12.8%, `error!` in a before filter +6.2% / +2.0%, an error
rendered by `rescue_from` +7.9% / +4.5%, a mounted API's GET +6.8% / +3.1%,
query params, a JSON body and a nested route +2.1% to +3.9%. A 405 on a
path-versioned API is -0.5% / -3.7%: a request the router did not match
now asks whether it was routed before falling through.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

1427 of 1482 branches covered (96.29%)

Branch coverage included in aggregate %.

16 of 16 new or added lines in 3 files covered. (100.0%)

4288 of 4288 relevant lines covered (100.0%)

28142.22 hits per line