supabase / storage / 35241739237

83%

Build Type

push

github

Committed by web-flow

Commit Message

perf: avoid closure allocation in splitCacheControlDirectives (#1405)

## What kind of change does this PR introduce?

Perf

## What is the current behavior?

Uses closure for DRY-er code at the cost of some performance

## What is the new behavior?

Duplicate code and perform operation inline to optimize hot path

## Benchmark

| Case | Closure (ms) | Inline (ms) | Speedup |
|---|---:|---:|---:|
| `no-cache` | 62.3 | 16.8 | 3.72x |
| `max-age=3600` | 68.3 | 25.1 | 2.72x |
| `public, max-age=3600` | 89.3 | 43.2 | 2.07x |
| Full Storage output (`public, max-age, stale-while-revalidate,
stale-if-error`) | 203.5 | 141.0 | 1.44x |
| Object cache-control + etag revalidation nudge (`must-revalidate`) |
129.6 | 79.6 | 1.63x |
| One quoted segment with embedded commas | 138.4 | 89.2 | 1.55x |
| 100 short comma-separated directives | 1628.9 | 1444.2 | 1.13x |
| 5,000 short comma-separated directives | 788.6 | 754.0 | 1.05x |
| 100 independent quoted segments | 3574.6 | 3421.3 | 1.04x |
| Long unquoted value, no commas (10,000 chars) | 676.1 | 632.2 | 1.07x
|
| Long unquoted value, no commas (200,000 chars) | 504.6 | 441.1 | 1.14x
|
| Long quoted value with many escapes (50,000 pairs) | 169.3 | 161.3 |
1.05x |

Coverage Stats

6762 of 8660 branches covered (78.08%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

12225 of 14167 relevant lines covered (86.29%)

3056.25 hits per line