supabase / storage / 35236575468

83%

push

github

feat: allow setting stale-while-revalidate and stale-if-error headers (#1369)

## What kind of change does this PR introduce?

feature

## What is the current behavior?

A `stale-while-revalidate` header is only added for mismatched etag and
`stale-if-error` is never set

## What is the new behavior?

- Set `stale-while-revalidate` and `stale-if-error` headers based on env
config
- For mismatched etags use the configured value if set (otherwise
fallback to existing behavior - 30s hard coded)
- Correctly merge and de-dupe cache control directives

This PR should not change any behavior unless
`RESPONSE_STALE_WHILE_REVALIDATE` or `RESPONSE_STALE_IF_ERROR` are set.

6760 of 8658 branches covered (78.08%)

Branch coverage included in aggregate %.

54 of 54 new or added lines in 3 files covered. (100.0%)

12227 of 14167 relevant lines covered (86.31%)

3056.21 hits per line