source-academy / frontend / 35235495741

46%

push

github

fix(sicp): syntax-highlight SICPy code snippets as Python, not JavaScript (#4382)

* fix(sicp): syntax-highlight SICPy code snippets as Python, not JavaScript

CodeSnippet.tsx hardcoded language="javascript" for every rendered
snippet, and ParseJson.tsx's parseArr/parseObj/processingFunctions had
no notion of which edition (SICP JS vs. SICPy) they were parsing, so
this was never plumbed through for the Python edition either. Every
SICPy code snippet was tokenized as JavaScript, so keywords with no JS
equivalent (def, nonlocal, elif, lambda, ...) were never highlighted,
while overlapping keywords (if/else/return/class/...) looked fine by
coincidence, masking the bug for most snippets.

- Thread a SnippetLanguage ('javascript' | 'python') parameter through
  parseArr/parseObj/processingFunctions/handle* down to CodeSnippet,
  defaulting to 'javascript' so the JS edition (and existing tests)
  are unaffected.
- useSicPySectionQuery now passes 'python'.
- CodeSnippet takes an optional `language` prop (default 'javascript')
  instead of hardcoding it, and forwards it to react-syntax-highlighter.
- Register the 'python' PrismLight grammar in src/index.tsx alongside
  the existing 'javascript' one.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* fix(sicp): apply Python highlighting to disabled snippets, destructure CodeSnippet props

- Disabled-eval SICPy snippets (eval: false) rendered through a plain
  Blueprint Pre and never received the language prop, so they stayed
  unhighlighted even after Python support was wired in. Render them
  through the same PrismLight/SourceTheme path as evaluated snippets.
- Destructure CodeSnippetProps in the function parameter instead of
  the function body, per this repo's coding guidelines.

Addresses CodeRabbit review comments on PR #4382.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

3167 of 7884 branches covered (40.17%)

Branch coverage included in aggregate %.

31 of 32 new or added lines in 1 file covered. (96.88%)

7173 of 14674 relevant lines covered (48.88%)

31.56 hits per line