source-academy / frontend / 35233472003

46%

push

github

fix(sicp): give paragraphs half a line of vertical spacing (#4383)

.sicp-text's margin-bottom had been dead CSS since the interactive
SICP feature's original implementation: .sicp-content p { display:
inline } (0-1-1 specificity) always beat the plain .sicp-text rule
(0-1-0), and margin-bottom has no layout effect on an inline box. The
only visible gap between paragraphs came from incidental line-box
half-leading (~18px at the book's 16pt/line-height:2), not from any
deliberate value — every <p> the JSON-based renderer emits (SICP JS
and SICPy alike; ParseJson.tsx's TEXT handler is the sole producer)
was affected identically, since both editions share this stylesheet
and component.

Excludes .sicp-text from the inline rule and gives it real block
layout with margin-bottom: 1em — exactly half of the unitless
line-height: 2 (2 x font-size), so it stays exactly half a line at
any font-size this stylesheet uses. Verified by measuring the actual
rendered gap between two stacked paragraphs before and after: ~18px
(incidental) -> 21.33px (== half of the computed 42.67px line-height,
matching to sub-pixel rounding).

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

3164 of 7881 branches covered (40.15%)

Branch coverage included in aggregate %.

7174 of 14675 relevant lines covered (48.89%)

31.55 hits per line