IJHack / QtPass / 35232092867

93%

Build Type

push

github

Committed by web-flow

Commit Message

ConfigDialog: a profile list with a form instead of the table (#1815)

* ConfigDialog: a profile list with a form instead of the table

The Profiles tab was a QTableWidget with three editable columns, Add and
Delete under it, and the profile's Git flags edited through the global
checkboxes on the Settings tab for whichever row happened to be selected.
Sorting the table while typing moved rows under the editor, and two rows
with the same name silently collapsed into one on save.

The tab is now a QListWidget of names next to a form: name, store path
with a folder picker, signing key (placeholder says it is a fingerprint,
which is what verification needs) and the profile's own Use Git / push /
pull boxes, which show the global values until clicked. The dialog keeps
the profiles as a QList of (name, Profile) so a profile can pass through
an empty or duplicate name while it is typed; validate() paints such rows
red in the list, puts the reason in the field's tooltip and keeps OK
disabled. On accept the active profile's own Git flags replace the global
ones, as switching to it does.

tst_configdialog: the sort regression test becomes a plain add test, plus
the form round trip (edits land in getProfiles(), switching profiles
keeps them apart, untouched Git boxes leave the optional unset) and the OK
gating for empty name, duplicate name, empty path and deletion. The three
new labels join the buddy check.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* Profiles: keep designer tooltips, follow the active profile through edits

Review follow-ups:

- validate() replaced the form fields' designer tooltips with the problem
  text and left them empty once the problem was gone; the originals are
  cached and put back. loadProfileForm() validates, so the tooltips of a
  freshly selected profile are right without an edit.
- The active profile scalar did not move with a rename and survive... (continued)

Coverage Stats

133 of 138 new or added lines in 1 file covered. (96.38%)

31 existing lines in 4 files now uncovered.

6073 of 7901 relevant lines covered (76.86%)

75.63 hits per line