cameri / nats-server / 35183236484
83%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 66
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 80.726% (+8.1%) from 72.638%
35183236484

push

github

web-flow 
[FIXED] Remove stale JetStream account usage after peer removal (#8570)

Fixes #8563.

When a JetStream server is permanently removed from the cluster, its
last reported account usage can remain in `jsAccount.rusage`. Because
that value is still included in the account totals, replacing a stream
replica on another server can cause storage usage to be counted twice.

I reproduced this with a 4-node cluster and an R3 stream. After removing
one of the replica-holding servers and letting the stream move to the
spare node, the stream was still correctly running with 3 replicas, but
the account storage usage increased as if there were 4 copies.

This change removes the departed server's usage when its meta peer
removal is committed. It also ignores a late usage update from the
removed node so that the stale entry cannot be added back after cleanup.

I added a regression test that:

* creates an R3 stream on a 4-node cluster,
* verifies the initial account usage,
* removes one of the servers hosting a replica,
* waits for the replica to move to the spare server,
* verifies the account usage stays unchanged,
* and checks that a late usage update from the removed peer does not
recreate the stale entry.

Testing:

* new regression test passes repeatedly
* regression test passes with `-race`
* related peer-removal and account-usage tests pass
* `go vet ./server`
* `git diff --check`

69774 of 86433 relevant lines covered (80.73%)

332217.88 hits per line

Coverage Regressions

Lines Coverage ∆ File
37
78.26
-0.29% src/github.com/nats-io/nats-server/server/raft.go
26
83.26
0.94% src/github.com/nats-io/nats-server/server/jetstream_cluster.go
18
73.67
12.19% src/github.com/nats-io/nats-server/server/jetstream_api.go
9
87.4
2.94% src/github.com/nats-io/nats-server/server/consumer.go
9
63.47
3.16% src/github.com/nats-io/nats-server/server/opts.go
8
78.55
1.83% src/github.com/nats-io/nats-server/server/filestore.go
5
61.26
9.57% src/github.com/nats-io/nats-server/server/reload.go
2
85.74
7.95% src/github.com/nats-io/nats-server/server/accounts.go
2
84.67
1.07% src/github.com/nats-io/nats-server/server/events.go
2
84.49
9.5% src/github.com/nats-io/nats-server/server/jetstream.go
2
98.44
0.0% src/github.com/nats-io/nats-server/server/jetstream_versioning.go
2
85.84
11.11% src/github.com/nats-io/nats-server/server/stream.go
Jobs
ID Job ID Ran Files Coverage
1 35183236484.1 66
80.73
GitHub Action Run
Source Files on build 35183236484