cameri / nats-server / 35056944155
81%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 66
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 72.638% (-10.0%) from 82.614%
35056944155

push

github

web-flow 
[FIXED] Remove stale JetStream account usage after peer removal (#8570)

Fixes #8563.

When a JetStream server is permanently removed from the cluster, its
last reported account usage can remain in `jsAccount.rusage`. Because
that value is still included in the account totals, replacing a stream
replica on another server can cause storage usage to be counted twice.

I reproduced this with a 4-node cluster and an R3 stream. After removing
one of the replica-holding servers and letting the stream move to the
spare node, the stream was still correctly running with 3 replicas, but
the account storage usage increased as if there were 4 copies.

This change removes the departed server's usage when its meta peer
removal is committed. It also ignores a late usage update from the
removed node so that the stale entry cannot be added back after cleanup.

I added a regression test that:

* creates an R3 stream on a 4-node cluster,
* verifies the initial account usage,
* removes one of the servers hosting a replica,
* waits for the replica to move to the spare server,
* verifies the account usage stays unchanged,
* and checks that a late usage update from the removed peer does not
recreate the stale entry.

Testing:

* new regression test passes repeatedly
* regression test passes with `-race`
* related peer-removal and account-usage tests pass
* `go vet ./server`
* `git diff --check`

62783 of 86433 relevant lines covered (72.64%)

253104.45 hits per line

Coverage Regressions

Lines Coverage ∆ File
2429
24.45
-64.07% src/github.com/nats-io/nats-server/server/mqtt.go
730
60.32
-17.45% src/github.com/nats-io/nats-server/server/opts.go
720
74.73
-11.44% src/github.com/nats-io/nats-server/server/stream.go
499
61.48
-12.47% src/github.com/nats-io/nats-server/server/jetstream_api.go
470
69.22
-17.45% src/github.com/nats-io/nats-server/server/monitor.go
363
74.33
-15.15% src/github.com/nats-io/nats-server/server/leafnode.go
343
65.16
-16.17% src/github.com/nats-io/nats-server/server/memstore.go
271
77.78
-8.73% src/github.com/nats-io/nats-server/server/accounts.go
257
51.69
-15.77% src/github.com/nats-io/nats-server/server/reload.go
240
87.09
-5.85% src/github.com/nats-io/nats-server/server/client.go
239
43.64
-22.34% src/github.com/nats-io/nats-server/server/websocket.go
226
39.97
-15.53% src/github.com/nats-io/nats-server/server/jetstream_errors_generated.go
214
44.85
-45.92% src/github.com/nats-io/nats-server/server/msgtrace.go
190
74.99
-9.6% src/github.com/nats-io/nats-server/server/jetstream.go
145
76.72
-1.42% src/github.com/nats-io/nats-server/server/filestore.go
144
75.31
-12.09% src/github.com/nats-io/nats-server/server/auth.go
143
84.47
-2.98% src/github.com/nats-io/nats-server/server/consumer.go
119
84.94
-4.35% src/github.com/nats-io/nats-server/server/server.go
115
82.32
-0.51% src/github.com/nats-io/nats-server/server/jetstream_cluster.go
112
0.0
-52.83% src/github.com/nats-io/nats-server/server/proto.go
102
78.55
-2.1% src/github.com/nats-io/nats-server/server/raft.go
95
2.44
-57.93% src/github.com/nats-io/nats-server/server/cron.go
85
80.82
-3.96% src/github.com/nats-io/nats-server/server/route.go
78
46.22
-16.39% src/github.com/nats-io/nats-server/server/dirstore.go
70
81.7
-9.42% src/github.com/nats-io/nats-server/server/parser.go
63
42.44
-36.63% src/github.com/nats-io/nats-server/server/jwt.go
40
83.6
-1.94% src/github.com/nats-io/nats-server/server/events.go
38
54.72
-23.9% src/github.com/nats-io/nats-server/server/log.go
37
87.26
-5.35% src/github.com/nats-io/nats-server/server/jetstream_batching.go
34
8.11
-91.89% src/github.com/nats-io/nats-server/server/monitor_sort_opts.go
32
62.88
-7.57% src/github.com/nats-io/nats-server/server/stream_backup.go
25
88.12
-2.38% src/github.com/nats-io/nats-server/server/sublist.go
14
80.59
-5.91% src/github.com/nats-io/nats-server/server/scheduler.go
14
57.35
-3.37% src/github.com/nats-io/nats-server/server/subject_transform.go
12
10.38
-11.32% src/github.com/nats-io/nats-server/server/signal.go
9
70.49
-14.75% src/github.com/nats-io/nats-server/server/feature_flags.go
9
75.81
-3.25% src/github.com/nats-io/nats-server/server/store.go
8
93.14
-0.38% src/github.com/nats-io/nats-server/server/gateway.go
8
82.63
-3.76% src/github.com/nats-io/nats-server/server/util.go
5
70.31
-7.81% src/github.com/nats-io/nats-server/server/errors.go
2
80.96
-0.48% src/github.com/nats-io/nats-server/server/avl/seqset.go
2
98.44
-1.56% src/github.com/nats-io/nats-server/server/jetstream_versioning.go
Jobs
ID Job ID Ran Files Coverage
1 35056944155.1 66
72.64
GitHub Action Run
Source Files on build 35056944155