umputun / agterm / 35166828520
94%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 146
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 92.975%. Remained the same
35166828520

push

github

web-flow 
fix missing icons and modal crashes with comma-decimal locales (#615)

* fix missing icons and modal crashes with comma-decimal locales

libghostty adopts the user's C locale during `ghostty_init`, and CoreSVG parses SF Symbol geometry through it. Under a comma decimal separator symbols come back badly mis-sized and draw missing or malformed. On macOS 27 a zero-sized rasterization inside a modal's render aborts the process. This can crash modal alerts, including the quit confirmation, which then bypasses the exit capture in `applicationWillTerminate`.

pin `LC_NUMERIC` to C right after `ghostty_init`, before the first symbol lookup caches its geometry. `LC_CTYPE` keeps the adopted value and the environment is untouched, so spawned shells still inherit the user's locale.

the hosted test scheme now runs under a comma-decimal locale so the regression test is real: without the pin it fails with ru_RU.UTF-8 instead of C.

Fixed #611

* pin the numeric locale even when ghostty_init fails

libghostty's ensureLocale adopts the user's locale early in ghostty_init, ahead of its own fallible steps, so an init that failed after that point returned before the pin. The UI keeps running with a comma numeric locale after initialization fails.

* build zmx under the macOS 27 SDK

the SDK's math.h asks the compiler's float.h for INFINITY and NAN through clang's `__need_infinity_nan` protocol, and zig 0.16's bundled float.h does not implement it, so compiling zig's libc++ fails. Only the zmx build is affected: libghostty compiles against Ghostty's own apple-sdk math.h overlay, while zmx's exported VT dependency path does not.

setup.sh now shims the two macros into zig's float.h before building zmx. It generates the replacement before installing it atomically and keeps the original as a backup, since a half-applied header breaks every consumer of the shared zig keg. A header that already implements the protocol upstream is left alone. The shim can be removed once ZIG_F... (continued)

11368 of 12227 relevant lines covered (92.97%)

3337357.23 hits per line

Jobs
ID Job ID Ran Files Coverage
1 35166828520.1 146
92.97
 GitHub Action Run
Source Files on build 35166828520