decentraland / social-service-ea / 35149834025

91%

main: 91%

Build Type

Pull #480

github

Committed by LautaroPetaccio

Commit Message

fix: do not announce the start of a community voice chat that already ended

The cache entry is written before the thumbnail and places lookups, so the room
is announceable to the ended event handler while the start is still being
enriched. A creator who connects and leaves in that window had their end
announced first and the in-flight start then announced a dead room.

The start now checks the entry is still cached before publishing, and returns
the credentials without announcing when it is gone. The cache gets its plain
read back for it.

Pull Request Pull Request #480: feat: end community voice chats on the gatekeeper event instead of polling

Coverage Stats

2577 of 2968 branches covered (86.83%)

Branch coverage included in aggregate %.

54 of 56 new or added lines in 6 files covered. (96.43%)

3 existing lines in 1 file now uncovered.

6228 of 6674 relevant lines covered (93.32%)

93.9 hits per line