decentraland / social-service-ea / 35147942291

91%

main: 91%

Build Type

Pull #480

github

Committed by LautaroPetaccio

Commit Message

fix: let the ended event handler be the only announcer of a community voice chat end

The explicit end took the cache entry, asked the gatekeeper to end the room and
published its own update. The gatekeeper publishes the ended event inside that
call, so the handler could process it while the entry was absent and drop it as
nothing to end; a failed inline publish then restored an entry nothing would
consume. The explicit end now only ends the room; the handler announces every
end the same way, so there is one announcer and no interleaving to lose the entry
in. The cache's unused get and remove methods are gone with it.

Pull Request Pull Request #480: feat: end community voice chats on the gatekeeper event instead of polling

Coverage Stats

2575 of 2964 branches covered (86.88%)

Branch coverage included in aggregate %.

45 of 46 new or added lines in 5 files covered. (97.83%)

3 existing lines in 1 file now uncovered.

6220 of 6665 relevant lines covered (93.32%)

93.95 hits per line