Tatsh / wiswa / 35096805916

100%

push

github

typing: make the VS Code launch setting optional

`VSCode.launch` was required and non-optional. The tests already build a
settings mapping with `launch` set to `None`, and a settings mapping
assembled outside the Jsonnet merge may omit the key entirely. The
annotation becomes `NotRequired[VSCodeLaunch | None]`.

The one consumer subscripted the key three times in the cleanup branch
for a project without tests. An absent key would raise `KeyError` there,
and mypy does not flag a subscript on a `NotRequired` key. The lookup
moves to `.get` bound with the walrus operator, and the two further
reads take the bound value.

Default settings always write `vscode.launch`, and generated output does
not change. The existing test for the `None` case gains a parametrised
case for the absent key.

Signed-off-by: Andrew Udvare <audvare@gmail.com>

788 of 788 branches covered (100.0%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

2040 of 2040 relevant lines covered (100.0%)

5.0 hits per line