hyperledger-labs / fabric-smart-client / 35079462385

91%

Build Type

push

github

Committed by web-flow

Commit Message

refactor!: retire utils.IsNil (#1855)

utils.IsNil used reflection to check whether a generic value's pointer,
slice, map, chan, func, or interface is nil, but iterators.flatten.go was
its only caller outside its own test. A reflection-based nil check doesn't
need to be public API for one internal use.

Move it into the iterators package as an unexported isNil next to
flatten.go, its only caller, and drop IsNil and its test from utils.
flatten_internal_test.go carries the same test cases forward, calling
isNil directly.

BREAKING CHANGE: utils.IsNil is removed, with no replacement in package
utils. A caller that needs a generic reflection-based nil check should
keep it locally, scoped to its own package.

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

5 of 5 new or added lines in 1 file covered. (100.0%)

23 existing lines in 8 files now uncovered.

27335 of 31951 relevant lines covered (85.55%)

2318.33 hits per line