firezone / boringtun / 35065343104

39%

push

github

fix: expire the tunnel when a used session expires (#246)

Both peers derive a session's lifetime from the same handshake, so they
discard it at the same instant. A session that carried data was due a
re-key at `REKEY_AFTER_TIME`, which leaves a full minute of retries
before `REJECT_AFTER_TIME`, so surviving to the expiry means that re-key
never landed and there is no shared state left for a handshake to reach.
We started one anyway and only surfaced `ConnectionExpired` a further
`REKEY_ATTEMPT_TIME` later, so a peer that was unreachable across the
re-key window cost its caller 90s of handshaking into nothing before
being told to rebuild. A suspended client is exactly that peer.

A session that carried nothing was never due a re-key, so its expiry
says nothing about the remote and a fresh handshake still reaches it.
That covers a caller going quiet, including the case where the last
re-key handed over a session that was then never used, so it stays as it
was.

---------

Co-authored-by: Claude <noreply@anthropic.com>

18 of 18 new or added lines in 1 file covered. (100.0%)

1665 of 4248 relevant lines covered (39.19%)

816.64 hits per line