firezone / boringtun / 35056815922

39%

push

github

fix: consume the passive keepalive deadline when it fires (#244)

The deadline saying we owe the other side a keepalive was only ever
cleared as a side effect of a successful send. When the send failed, the
deadline stayed in the past, so every later poll read it as due, told
the caller to come straight back, and got nowhere.

Clearing it alongside the current session covered one way to lose that
session, but a peer can reach the keepalive branch with an empty session
slot it never dropped there, and then nothing clears the deadline at
all. It is a one-shot, so it is now consumed where it fires. That covers
every way the send can fail, including the errors that propagate rather
than being swallowed, and it matches the persistent keepalive
immediately below, which has always advanced its own timer at fire time
for the same reason.

Recovery is unchanged: the deadline re-arms on the next packet we
receive, and the handshake timers own getting a session back.

Related: #243

Co-authored-by: Claude <noreply@anthropic.com>

1 of 1 new or added line in 1 file covered. (100.0%)

1652 of 4235 relevant lines covered (39.01%)

807.62 hits per line