FlexMeasures / flexmeasures / 35036966808

85%

main: 86%

push

github

Log one line when the CLI rejects an option value

A reporting cron job stopped producing data, and the log file the wrapper
script writes held no trace of why. The command had a stray --start, which
swallowed the option that followed it as its value, and Click rejected that
as a datetime. Click reports such errors on stderr alone, while the script
redirected only stdout, so nothing was recorded.

FlexMeasures configures a rotating file handler of its own, but an
invocation that fails while parsing its options never reaches any code that
logs, so that file stays silent too. The same goes for latest_task_runs,
which is filled by a decorator around the command body.

Add LoggedClickExceptionCommand, which logs one ERROR line naming the
command and the message Click would print, and re-raises so that Click's
own output and its exit code are unchanged. One line, rather than the usage
block, keeps a repeatedly failing cron job from filling the log.

Applied to `flexmeasures add report` for now, which is the command this was
found on.

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

17 of 19 new or added lines in 2 files covered. (89.47%)

18477 of 21743 relevant lines covered (84.98%)

0.85 hits per line