FlexMeasures / flexmeasures / 34245198400

86%

Build Type

push

github

Committed by web-flow

Commit Message

Settle which source wins an event with one rule, in two steps (#2494)

* Count an event once in a KPI, when several sources report it

Two sources reporting one event are two claims about it, not two contributions to it, so adding them
up produced a number no source ever reported, and that no point on the chart showed. A sensor with a
forecast later corrected by an upload, or with two forecasters configured differently, totalled both.

The KPI query now asks for one deterministic belief per event, which prefers the latest source
version, and the most recent belief within it. `most_recent_beliefs_only` alone did not do this: it
is per source, and `use_latest_version_per_event` only collapses sources sharing a name, type and
model, and only within one belief time.

The chart beside the KPI still draws every source, so it can show more points than the KPI counted,
which the KPI documentation now says.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lp1bUhWjEQtyDbnvRZQgQs
Signed-off-by: F.N. Claessen <claessen@seita.nl>

* docs/changelog: record the KPI fix

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lp1bUhWjEQtyDbnvRZQgQs
Signed-off-by: F.N. Claessen <claessen@seita.nl>

* tests: cover the version priority a KPI applies, and say where ties stop

The regression test only varied the belief time, while the docstring and the documentation also
claimed a preference for the latest source version, which the fixture's unversioned sources could not
show. A second test now gives one reporter two versions and has the newer one speak first, so the
KPI answers with the newer version's value despite the older belief time.

Ties beyond that are left alone, and `_select_latest_version_and_belief_per_event` now says why:
beliefs which tie on version and belief time keep the order they came in, which is how a caller
expresses its own precedence by the order ... (continued)

Coverage Stats

63 of 69 new or added lines in 2 files covered. (91.3%)

1 existing line in 1 file now uncovered.

18461 of 21725 relevant lines covered (84.98%)

0.85 hits per line