nette / command-line / 35022865550

98%

push

github

Console: one console per stream, with a status drawn in place (BC break)

A console is one stream and its colors, width and terminal follow that stream, so
an application writing to stdout and stderr makes one for each and a redirected
output cannot decide the colors of the other. Both answers can be given to the
constructor, which is what --no-color needs and what lets a test drive a memory
stream. The static detectColors() and detectTerminal() became hasColors() and
isTerminal(), useColors() needs its argument, color() takes the text and refuses
an unknown name, or anything but a foreground and a background, even with colors
off, and write() strips the sequences the text already carried, so nothing
colored leaves a console whose colors are off.

setStatus() draws lines in place, cut to the width of the terminal, with the
cursor hidden and shown again on shutdown; the next write() erases them and the
next setStatus() draws them again below it. It takes whole lines, so a status
never erases output that did not end with one, and nothing to draw erases the
status instead of drawing an empty one. It is the line rewriting every progress
bar wrote by hand, and it does nothing where the stream is not a terminal, so a
redirected output holds only the real lines.

Ansi measures and cuts text the way the terminal shows it, an escape sequence
taking no column and a wide character two, and is now the single measure the help
and any column of an application share. Nothing it returns is wider than asked,
an ellipsis that would not fit being left out, which is what a status cut to a
narrow terminal depends on. The constants ClearLine, Reset, BoldOn and BoldOff
are gone; a status needs none of them.

An optional value also takes the next token when the option has an enum and the
token is one of its values, so that a line like `tester --colors 0` cannot
silently mean the opposite of what it says, while nothing outside the enum is
ever swallowed.

130 of 134 new or added lines in 4 files covered. (97.01%)

653 of 671 relevant lines covered (97.32%)

0.97 hits per line