solidjs / solid / 35009261199

74%

main: 89%

push

github

chore(solid,web,universal): the runtimes' seams move behind solid-js/internal (#3470)

* chore(solid,web,universal): the runtimes' seams move behind solid-js/internal

`merge()`/`omit()` returning lazy views (#3454) gave `spread()` and
`ssrElement()` a protocol for reading props leaf by leaf instead of trapping
through the proxy per key. `@solidjs/web` and `@solidjs/universal` depend on
`solid-js` alone — never on `@solidjs/signals` directly, so an app holds
exactly one reactive engine — so every piece of that protocol went out through
`solid-js`'s main export: eleven names, `mergeSources` before them in #3325,
on the public surface with no marking. None of it is API.

`solid-js/internal` is now their home: the view protocol (`viewOf`,
`mergeView`/`omitView`, `MergeView`/`OmitView`, `sourceKeys`/`sourceHas`/
`sourceGet`, `hasStaticKeys`, `resolvedTable`, the `SOURCE_*` kinds), and the
server-scope seams that were already `@internal` in JSDoc and consumed only by
`@solidjs/web` (`ssrHandleError`, `ssrScope`, `runInServerComponentScope`,
`inServerComponentScope`, `creationStamp`, `getProjectionTrace`,
`materializeContainerTrace`).

The names stay exported from the main entries AT RUNTIME, so the subpath
shares one module state and the single-engine guarantee is untouched; they
carry `@internal` and `stripInternal` keeps them out of the generated
declarations, which is what makes them not-public for TypeScript. The protocol
half re-exports `@solidjs/signals` as-is; the seams are read back from
"solid-js" (external, so the platform/tier conditions pick the same build the
app runs) and declared with their signatures spelled out, since the main
entries no longer type them.

Dropped from the entries as dead: `storeIsShallow`, `storeHasFamily`,
`storeHasOptimisticFamily` (leftovers of the gutted patch channel),
`storePath` and `$REFRESH` (referenced only by `@solidjs/signals`'s own
internals), `NoHydrateContext` (`@internal`, used only by `solid-js`'s server
... (continued)

520 of 790 branches covered (65.82%)

Branch coverage included in aggregate %.

0 of 7 new or added lines in 1 file covered. (0.0%)

772 of 1014 relevant lines covered (76.13%)

14.98 hits per line