TYPO3BestPractices / tea / 34999085051
100%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 6
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
34999085051

push

github

web-flow 
[TASK] Run the CI containers with docker (#2322)

GitHub hosted runners ship both podman and docker, and `runTests.sh`
selects podman whenever it is available. On the `ubuntu-26.04` runners
the MariaDB container of the functional tests is never reachable under
podman: the readiness check fails with "nc: bad address" from its
first attempt on, while the same run passes locally with podman as
well as with docker, and MySQL and PostgreSQL pass on CI.

The workflows now pass `-b docker` to every `runTests.sh` call. The
script default stays podman first, which is right for local runs, and
the reason is noted in the workflow headers, so the flag can be
dropped knowingly later.

`waitFor()` did not abort either. `kill -SIGINT -$$` relies on the
SIGINT trap, which is only installed when `CI` is not `true`, so on
CI the kill was a no-op, the run continued and PHPUnit reported dozens
of connection errors instead of the readiness timeout that actually
happened. `waitFor()` now cleans up and exits directly. Its budget is
raised from about 20 to 60 seconds to leave a wide margin for the
slower database start under docker.

Under docker, `runTests.sh` runs the containers as the host user,
whose uid has no passwd entry in the testing images on the runners,
so the containers see `/` as home directory. Composer then fails to
create its global configuration below `/.composer`, which breaks the
"Show the Composer configuration" step of every PHP job, and `npm ci`
finds no writable cache. `COMPOSER_HOME` and the npm cache now point
into the git-ignored `.cache` directory for every container that runs
Composer or npm.

Both changes follow what other extensions using the same harness
already did:

* fgtclb/academic-extensions#367 and web-vision/deepltranslate-core#614
  run the CI containers with docker.
* fgtclb/academic-extensions#381 and web-vision/deepltranslate-core#616
  make `waitFor()` abort and wait longer.

Verified locally under docker with TYPO3 13.4 and PHP 8.... (continued)

129 of 129 relevant lines covered (100.0%)

5.64 hits per line

Jobs
ID Job ID Ran Files Coverage
1 34999085051.1 6
100.0
 GitHub Action Run
Source Files on build 34999085051